Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better creds for full tests #453

Merged
merged 9 commits into from
Oct 25, 2022
Merged

Better creds for full tests #453

merged 9 commits into from
Oct 25, 2022

Conversation

pballandras
Copy link

@pballandras pballandras commented Oct 21, 2022

Now assumes role for full test instead of relying on hardcoded credentials

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #453 (c4ba0bf) into master (fb16b01) will increase coverage by 0.38%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   55.60%   55.98%   +0.38%     
==========================================
  Files          58       58              
  Lines        5928     5934       +6     
==========================================
+ Hits         3296     3322      +26     
+ Misses       2303     2284      -19     
+ Partials      329      328       -1     
Impacted Files Coverage Δ
awshelper/parameter_store.go 33.33% <33.33%> (ø)
util/file.go 59.44% <100.00%> (+7.65%) ⬆️
configstack/test_helpers.go 84.73% <0.00%> (+0.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pballandras pballandras marked this pull request as ready for review October 24, 2022 19:03
@pballandras pballandras requested review from a team October 24, 2022 19:04
@pballandras pballandras merged commit d4e88ac into master Oct 25, 2022
@pballandras pballandras deleted the fix/dt-4933-credentials branch October 25, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants