add missing flag for module completion #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocgir
reviewed
Feb 12, 2018
- Add the worker number to the traces to help identify the running thread
jocgir
previously approved these changes
Feb 12, 2018
lpbedard
commented
Feb 12, 2018
configstack/running_module.go
Outdated
| go module.OutputPeriodicLogs(&completed) // Flush the output buffers periodically to confirm that the process is still alive | ||
| module.runModuleWhenReady() | ||
| completed = true |
There was a problem hiding this comment.
Do we still need this line if it is now in the defer func?
jocgir
approved these changes
Feb 12, 2018
configstack/running_module.go
Outdated
| go module.OutputPeriodicLogs(&completed) // Flush the output buffers periodically to confirm that the process is still alive | ||
| module.runModuleWhenReady() | ||
| completed = true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.