Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type information to collection types #94

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Add type information to collection types #94

merged 2 commits into from
Dec 11, 2019

Conversation

jocgir
Copy link
Contributor

@jocgir jocgir commented Dec 11, 2019

  • Add Type(), GetTypes() and GetKinds() to all collection objects.
  • Fix bug with genny template generation

jocgir added 2 commits May 21, 2019 06:35
@jocgir
Add type information to collection types
4a42ffa 
- Add Type(), GetTypes() and GetKinds() to all collection objects.
- Fix bug with genny template generation
@jocgir
Merge branch 'master' into features/add-type-information-to-collections
72dbc91
@codecov-io
Copy link

Codecov Report

Merging #94 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   55.83%   56.25%   +0.42%     
==========================================
  Files          62       62              
  Lines        4673     4718      +45     
==========================================
+ Hits         2609     2654      +45     
  Misses       1878     1878              
  Partials      186      186
Impacted Files Coverage Δ
collections/dictionary.go 0% <ø> (ø) ⬆️
json/generated_impl.go 97.53% <100%> (+0.19%) ⬆️
collections/implementation/generic.go 96.15% <100%> (+0.32%) ⬆️
xml/generated_impl.go 96.29% <100%> (+0.29%) ⬆️
yaml/generated_impl.go 97.53% <100%> (+0.19%) ⬆️
collections/implementation/list_helper.go 94.91% <100%> (+0.36%) ⬆️
collections/implementation/dict_helper.go 93.43% <100%> (+0.35%) ⬆️
hcl/generated_impl.go 97.53% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1130d3...72dbc91. Read the comment docs.

@jocgir jocgir merged commit 6b12b6f into master Dec 11, 2019
@jocgir jocgir deleted the features/add-type-information-to-collections branch December 11, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jocgir @codecov-io @julienduchesne