Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable color rendering on Windows #27

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Enable color rendering on Windows #27

merged 2 commits into from
Sep 11, 2018

Conversation

jocgir
Copy link
Contributor

@jocgir jocgir commented Sep 10, 2018

  • Refactor of some useful functions (moved from template to utils).
  • Integrate ProtecString/RestoreProtectedString/AddLineNumber to String object.
  • Use updated version of Genny (which results in different template rendering).
  • Remove the deprecated --quiet option.

@jocgir
Enable color rendering on Windows
703e16d 
- Refactor of some useful functions (moved from template to utils).
- Integrate ProtecString/RestoreProtectedString/AddLineNumber to String object.
- Use updated version of Genny (which results in different template rendering).
- Remove the deprecated --quiet option.
@jocgir jocgir force-pushed the fix-colors-on-windows branch from 7d29cdb to 703e16d Compare September 10, 2018 11:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 388

  • 173 of 214 (80.84%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 60.199%
Changes Missing Coverage Covered Lines Changed/Added Lines %
errors/errors.go 0 1 0.0%
template/extra_logging.go 0 1 0.0%
template/razor.go 14 15 93.33%
utils/io.go 4 6 66.67%
utils/regex.go 21 23 91.3%
template/template_process.go 4 9 44.44%
template/template_help.go 0 11 0.0%
utils/color.go 1 19 5.26%
Totals Coverage Status
Change from base Build 383: -0.001%
Covered Lines: 2845
Relevant Lines: 4726
💛 - Coveralls

@jocgir
Fix problem with contains overriding the behaviour of Sprig contains
730a275 
The function has been enhanced to handle both list and strings
@jocgir jocgir merged commit 4dd327a into master Sep 11, 2018
@jocgir jocgir deleted the fix-colors-on-windows branch September 11, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblanchette dblanchette Awaiting requested review from dblanchette

@julienduchesne julienduchesne Awaiting requested review from julienduchesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jocgir @coveralls