Added Find and FindStrict methods to generic lists #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added strict mode on list search functions/methods Added Find and FindStrict methods to generic lists Added RemoveNil and RemoveEmpty methods to generic lists Added test to cover new functions Simplified the test structure
|
This looks as a big change, but in fact, a lot of this code is automatically generated by gogenerate. |
jocgir
changed the title
dblanchette
approved these changes
Jul 21, 2020
Co-authored-by: Denis Blanchette <dblanchette@coveo.com>
Co-authored-by: Denis Blanchette <dblanchette@coveo.com>
Co-authored-by: Denis Blanchette <dblanchette@coveo.com>
Co-authored-by: Denis Blanchette <dblanchette@coveo.com>
ycanty
reviewed
Jul 21, 2020
template/extra_data.go
Outdated
| @@ -189,6 +203,8 @@ var dataFuncsHelp = descriptions{ | |||
| "prepend": "Push elements onto the front of a list, creating a new list.", | |||
| "rest": "Gets the tail of the list (everything but the first item)", | |||
| "reverse": "Produces a new list with the reversed elements of the given list.", | |||
| "removeEmpty": "Returns a list will all empty element removed.", | |||
There was a problem hiding this comment.
Suggested change
| "removeEmpty": "Returns a list will all empty element removed.", | |
| "removeEmpty": "Returns a list with all empty elements removed.", |
template/extra_data.go
Outdated
| @@ -189,6 +203,8 @@ var dataFuncsHelp = descriptions{ | |||
| "prepend": "Push elements onto the front of a list, creating a new list.", | |||
| "rest": "Gets the tail of the list (everything but the first item)", | |||
| "reverse": "Produces a new list with the reversed elements of the given list.", | |||
| "removeEmpty": "Returns a list will all empty element removed.", | |||
| "removeNil": "Returns a list will all nil element removed.", | |||
There was a problem hiding this comment.
Suggested change
| "removeNil": "Returns a list will all nil element removed.", | |
| "removeNil": "Returns a list with all nil elements removed.", |
| @@ -163,12 +174,15 @@ var dataFuncsHelp = descriptions{ | |||
| "array": "Ensures that the supplied argument is an array (if it is already an array/slice, there is no change, if not, the argument is replaced by []interface{} with a single value).", | |||
| "bool": "Converts the `string` into boolean value (`string` must be `True`, `true`, `TRUE`, `1` or `False`, `false`, `FALSE`, `0`)", | |||
| "char": "Returns the character corresponging to the supplied integer value", | |||
| "contains": "Test to see if a list has a particular elements.", | |||
| "contains": "Test to see if a list has a particular elements (matches any types).", | |||
There was a problem hiding this comment.
Suggested change
| "contains": "Test to see if a list has a particular elements (matches any types).", | |
| "contains": "Tests whether a list contains all given elements (matches any types).", |
| @@ -163,12 +174,15 @@ var dataFuncsHelp = descriptions{ | |||
| "array": "Ensures that the supplied argument is an array (if it is already an array/slice, there is no change, if not, the argument is replaced by []interface{} with a single value).", | |||
| "bool": "Converts the `string` into boolean value (`string` must be `True`, `true`, `TRUE`, `1` or `False`, `false`, `FALSE`, `0`)", | |||
| "char": "Returns the character corresponging to the supplied integer value", | |||
| "contains": "Test to see if a list has a particular elements.", | |||
| "contains": "Test to see if a list has a particular elements (matches any types).", | |||
| "containsStrict": "Test to see if a list has a particular elements (matches only the same types).", | |||
There was a problem hiding this comment.
Suggested change
| "containsStrict": "Test to see if a list has a particular elements (matches only the same types).", | |
| "containsStrict": "Tests whether a list contains all given elements (matches only the same types).", |
| "extract": "Extracts values from a slice or a map, indexes could be either integers for slice or strings for maps", | ||
| "get": "Returns the value associated with the supplied map, key and map could be inverted for convenience (i.e. when using piping mode)", | ||
| "extract": "Extracts values from a slice or a map, indexes could be either integers for slice or strings for maps.", | ||
| "find": "Returns all index position where the element is found in the list (matches any types).", |
There was a problem hiding this comment.
Suggested change
| "find": "Returns all index position where the element is found in the list (matches any types).", | |
| "find": "Returns all index positions where the element is found in the list (matches any types).", |
| "get": "Returns the value associated with the supplied map, key and map could be inverted for convenience (i.e. when using piping mode)", | ||
| "extract": "Extracts values from a slice or a map, indexes could be either integers for slice or strings for maps.", | ||
| "find": "Returns all index position where the element is found in the list (matches any types).", | ||
| "findStrict": "Returns all index position where the element is found in the list (matches only the same types).", |
There was a problem hiding this comment.
Suggested change
| "findStrict": "Returns all index position where the element is found in the list (matches only the same types).", | |
| "findStrict": "Returns all index positions where the element is found in the list (matches only the same types).", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved BaseHelper methods in the right file
Added strict mode on list search functions/methods
Added Find and FindStrict methods to generic lists
Added RemoveNil and RemoveEmpty methods to generic lists
Added test to cover new functions
Simplified the test structure