Improvements/error management #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Internal template should handle <no value> error - ellipsis error should only report the error, not the file position - Add debugging information on error retry
- Multiline errors were not handled properly due to a bad regex conversion - Add more flexibility to set options on template - assert method has been renamed to avoid conflict with assert test package
I also changed the code to be less dumb
jocgir
force-pushed
the
improvements/error-management
branch
from
a3cd941 to
190dcd6
Compare
julienduchesne
approved these changes
Mar 17, 2020
| {"Invalid", "@typeOf(data(`\"a\": 1, \"b\": 2`))", `"<RUN_ERROR>"`, fmt.Errorf("")}, | ||
| {"Json", "@typeOf(data(`{\"a\": 1, \"b\": 2}`))", "json.jsonDict", nil}, | ||
| {"Yaml", "@typeOf(data(`a: 1\nb: 2`))", "yaml.yamlDict", nil}, | ||
| {"Flexible Hcl", "@typeOf(data(`a = 1 b = hello`))", "yaml.yamlDict", nil}, // TODO: Change that to hcl |
There was a problem hiding this comment.
TODO for now or later?
There was a problem hiding this comment.
Shit, I really don't remember. I merged an old branch that has never been submitted as a PR.
I would say later. I think that I wrote that test when I started to look at HCL2 when it was still in Beta IIRC.
| @@ -17,18 +17,25 @@ const ( | |||
| literalTripleBackticks = "_=!TRIPLE_BT!=_" | |||
There was a problem hiding this comment.
@ and triple backticks can't go in the reservedKeywords slice below?
There was a problem hiding this comment.
I don't think so. Too risky to induce side effects IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors were not reported correctly. If a system call returned multi-line error, only the first line was kept.
struct keyword has been added as a go reserved keyword (this avoided using a variable named struct)