Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update upload-artifacts & download-artifacts to v4 #4664

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

alexprudhomme
Copy link
Contributor

https://coveord.atlassian.net/browse/KIT-3725

Main change are that they are immutable now. We were never mutating them so not much work to update to v4

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.8 0
commerce 341.5 341.5 0
search 412.8 412.8 0
insight 402.1 402.1 0
recommendation 249.1 249.1 0
ssr 406.3 406.3 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh! I thought we had a couple of troublesome use case but I was wrong :)
Noice.

@louis-bompart
Copy link
Collaborator

Will need to backport to v2

@louis-bompart louis-bompart reopened this Nov 11, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 1953c6c Nov 11, 2024
185 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3725 branch November 11, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants