Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(headless): rename 'controllers' to 'methods' in ssr-commerce to stay consistent with ssr #4642

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(headless): rename 'controllers' to 'methods' in ssr-commerce to stay consistent with ssr #4642

merged 1 commit into from
Nov 7, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme requested a review from a team as a code owner November 6, 2024 20:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.7 236.7 0
commerce 341.3 341.3 0
search 412.5 412.5 0
insight 401.8 401.8 0
recommendation 249 249 0
ssr 406.2 406.2 0
ssr-commerce 353.6 353.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 7, 2024
@alexprudhomme alexprudhomme changed the title chore(headless); rename 'controllers' to 'methods' in ssr-commerce to stay consistent with ssr chore(headless): rename 'controllers' to 'methods' in ssr-commerce to stay consistent with ssr Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
fbeaudoincoveo
fbeaudoincoveo approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link this Jira to KIT-3716 (with a "replaces" relationship) and explain in a comment why KIT-3716 was rejected (we're making it consistent rather than introducing a breaking change).

@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 61ff4ea Nov 7, 2024
93 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3718 branch November 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@fpbrault fpbrault fpbrault approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexprudhomme @fpbrault @fbeaudoincoveo