Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(headless commerce react samples): use react package #4615

Merged
merged 19 commits into from
Nov 8, 2024

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Oct 31, 2024

Refactoring Imports:

  • Changed imports from @coveo/headless/ssr-commerce to @coveo/headless-react/ssr-commerce

State Management Improvements:

  • Simplified state management by removing direct state handling and using custom hooks (useBreadcrumbManager, useCart, useContext, useFacetGenerator, useInstantProducts) for managing state in components.

Component Simplification:

  • Removed unnecessary props and state management logic from components since the controller is now fetched using react hooks.

Page Component Enhancements:

  • Better state management using HydratedStateProvider and StaticStateProvider for handling server-side rendering and client-side hydration.

https://coveord.atlassian.net/browse/KIT-3699

Copy link

github-actions bot commented Oct 31, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.8 0
commerce 341.5 341.5 0
search 412.8 412.8 0
insight 402.1 402.1 0
recommendation 249.1 249.1 0
ssr 406.3 406.3 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Base automatically changed from KIT-3695 to master November 6, 2024 19:25
@y-lakhdar y-lakhdar added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 8, 2024
@alexprudhomme alexprudhomme removed this pull request from the merge queue due to a manual request Nov 8, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 6f5ba55 Nov 8, 2024
121 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3699 branch November 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants