Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): replace atomic-quickview Cypress tests with Playwright #4549

Merged
merged 23 commits into from
Nov 18, 2024
Merged

test(atomic): replace atomic-quickview Cypress tests with Playwright #4549

merged 23 commits into from
Nov 18, 2024

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar requested review from a team as code owners October 17, 2024 13:30
@y-lakhdar y-lakhdar changed the title test(atomic) Replace atomic-quickview Cypress tests with Playwright test(atomic): replace atomic-quickview Cypress tests with Playwright Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.8 0
commerce 341.5 341.5 0
search 412.8 412.8 0
insight 402.1 402.1 0
recommendation 249.1 249.1 0
ssr 406.3 406.3 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

alexprudhomme
alexprudhomme approved these changes Oct 17, 2024
View reviewed changes
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Outdated Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Outdated Show resolved Hide resolved
packages/atomic/cypress/e2e/result-list/result-components/quickview.cypress.ts Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Outdated Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Outdated Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Show resolved Hide resolved
.../atomic/src/components/search/result-template-components/atomic-quickview/e2e/page-object.ts Outdated Show resolved Hide resolved
@alexprudhomme
Copy link
Contributor

alexprudhomme commented Oct 17, 2024 •
edited
Loading

The tests are not running. There is a bug in the script. https://sturdy-garbanzo-z4k4k6k.pages.github.io/4549/playwright-report/

@y-lakhdar y-lakhdar changed the base branch from master to KIT-3667 October 17, 2024 19:25
@y-lakhdar
Copy link
Contributor Author

The tests are not running. There is a bug in the script. https://sturdy-garbanzo-z4k4k6k.pages.github.io/4549/playwright-report/

Thanks @alexprudhomme .
Issue fixed in #4554

developer-experience-bot bot and others added 3 commits October 18, 2024 12:25
@developer-experience-bot
[Version Bump][skip ci]: ui-kit publish
ca534a2 
@coveo/atomic@3.5.0
@coveo/atomic-react@3.1.7
@coveo/atomic-angular@3.1.7
@coveo/quantic@3.2.2

**/CHANGELOG.md
**/package.json
CHANGELOG.md
package.json
package-lock.json
@y-lakhdar
Merge branch 'master' into KIT-3667
a55ae76
@y-lakhdar
Merge branch 'KIT-3667' into KIT-3657
f587129
Base automatically changed from KIT-3667 to master October 23, 2024 20:32
@github-actions github-actions bot requested a review from a team as a code owner October 23, 2024 20:32
@alexprudhomme alexprudhomme self-assigned this Nov 18, 2024
@y-lakhdar y-lakhdar added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit fdf0616 Nov 18, 2024
93 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3657 branch November 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@fpbrault fpbrault fpbrault approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees

@alexprudhomme alexprudhomme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y-lakhdar @alexprudhomme @fpbrault @louis-bompart