Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Demand Courses Download Feature #315

Merged
merged 6 commits into from
Mar 20, 2015
Merged

Conversation

mxamin
Copy link
Contributor

@mxamin mxamin commented Feb 21, 2015

As mentioned in issue #306, Coursera added new type of courses named On-Demand Courses like Calculus 1.
I have changed the code to support these new type of courses. All you have to do is to add --on-demand option when you are going to download the course, ex:
./coursera-dl -u <email> -p <password> --on-demand calculus1

It may have some incompatibility with other command option like --format, but I'm trying to fix them.

Added an authentication function which implements basic
user login procedure where client clicks `Signin` button
on coursera.org website and fills his/her Email and Password
to enter. In this procedure we use API Login v3 for authentication
and there is no need of `class_name` to fetch `csrftoken`.
This can be useful for future purposes, especially for downloading
`On-Demand` courses.
Now we can download on-demand courses like 'calculus1',
'beethoven-piano-sonatas' and etc. We can download these type of courses
by providing `--on-demand` option on command line. ex:
./coursera-dl -u <email> -p <password> --on-demand calculus1

Due to the difference between this type of courses with regular courses of
Coursera, options like '--format' may not work with this feature.
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.19%) to 65.99% when pulling d824fd4 on mxamin:ondemand into cb89e7c on coursera-dl:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.39%) to 71.57% when pulling e7ab764 on mxamin:ondemand into cb89e7c on coursera-dl:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.68%) to 72.87% when pulling baf9c10 on mxamin:ondemand into cb89e7c on coursera-dl:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+2.68%) to 72.87% when pulling baf9c10 on mxamin:ondemand into cb89e7c on coursera-dl:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.68%) to 72.87% when pulling baf9c10 on mxamin:ondemand into cb89e7c on coursera-dl:master.

rbrito added a commit that referenced this pull request Mar 20, 2015
On-Demand Courses Download Feature.

Thanks @mxamin for the nice contribution.

Closes #282, #306.
@rbrito rbrito merged commit 081979a into coursera-dl:master Mar 20, 2015
@mxamin mxamin deleted the ondemand branch May 5, 2015 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants