Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release docs for terraform version V1.4.0 #243

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Release docs for terraform version V1.4.0 #243

merged 7 commits into from
Dec 5, 2024
+305 −48

Conversation

a-atri
Copy link
Contributor

@a-atri a-atri commented Nov 20, 2024 •
edited
Loading

Jira

  • AV-87721

Description

Release Documentation for Terraform version V1.4.0

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code
  • I have made sure that no schema field is marked with both requiresReplace and computed

Further comments

@a-atri a-atri requested review from a team as code owners November 20, 2024 15:36
@a-atri a-atri requested review from simon-dew and rajagp November 21, 2024 08:31
simon-dew
simon-dew requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick scan of the documentation content. Couple of comments

docs/index.md Outdated Show resolved Hide resolved
docs/guides/1.4.0-upgrade-guide.md Show resolved Hide resolved
docs/guides/1.4.0-upgrade-guide.md Outdated Show resolved Hide resolved
simon-dew
simon-dew previously requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to previous comments

docs/guides/1.4.0-upgrade-guide.md Outdated Show resolved Hide resolved
@simon-dew simon-dew mentioned this pull request Nov 21, 2024
Open
14 tasks
a-atri and others added 3 commits November 25, 2024 13:04
@a-atri @simon-dew
Update docs/guides/1.4.0-upgrade-guide.md based on the feedback recei…
b0b7160 
…ved by the docs team

Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
@a-atri @rajagp @simon-dew
Adding suggested changes from the code review
0485bd8 
Co-authored-by: Priya Rajagopal <rajagp@users.noreply.github.com>
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
@a-atri
Added feature description in the index.md file
ed4a876
simon-dew
simon-dew reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of my comments from previous review still stand. I'm not requesting changes at this stage so as not to block the PR.

docs/index.md Show resolved Hide resolved
@simon-dew simon-dew dismissed their stale review November 29, 2024 13:46

Removing previous review as some comments have been addressed

nishant-tripathy
nishant-tripathy previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@nishant-tripathy nishant-tripathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-atri @PaulomeeCb
Apply suggestions from code review
b798057 
Updating the description for 'azure_network_peer_command' usage

Co-authored-by: Paulomee De <124640240+PaulomeeCb@users.noreply.github.com>
PaulomeeCb
PaulomeeCb approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@PaulomeeCb PaulomeeCb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, all comments resolved for network peers

@a-atri a-atri merged commit 3004f43 into main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-dew simon-dew simon-dew left review comments

@rajagp rajagp rajagp left review comments

@PaulomeeCb PaulomeeCb PaulomeeCb approved these changes

@nishant-tripathy nishant-tripathy nishant-tripathy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-atri @rajagp @simon-dew @nishant-tripathy @PaulomeeCb