Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: couchbase/gocb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.9.1
Choose a base ref
...
head repository: couchbase/gocb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.9.2
Choose a head ref
  • 12 commits
  • 29 files changed
  • 2 contributors

Commits on Jul 31, 2024

  1. GOCBC-1632: Add support for reading replicas from server groups

    Motivation
    ----------
    Operations do not currently take into account server groups. For
    reading from replica servers we need to provide a way for users to
    be able to read from specific groups, which can correspond to
    availablity zones. Doing so helps users to reduce costs of sending
    requests across availability zones.
    
    Changes
    --------
    Add PreferredServerGroup to cluster options and propagate it.
    Add ReadPreference to replica read function options.
    Wire in reading only from specified server group.
    
    Change-Id: I94443a58a7f97d8c80cfe8fca186d6c13faf3306
    Reviewed-on: https://review.couchbase.org/c/gocb/+/213459
    Reviewed-by: Dimitris Christodoulou <dimitris.christodoulou@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    chvck committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    99d9d7a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. GOCBC-1655: Fix typos in connstr timeout option errors

    Change-Id: Ibc63343c8ecac465dcaf81e243fb0641fa0869e0
    Reviewed-on: https://review.couchbase.org/c/gocb/+/213743
    Reviewed-by: Charles Dixon <chvckd@gmail.com>
    Tested-by: Build Bot <build@couchbase.com>
    DemetrisChr committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8a8ac06 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. TestCollectionsInBucket: Ensure scope is in all nodes before creating…

    … collections
    
    Change-Id: I9a281a7619a5fe2f563f0cfd4f589982356360e5
    Reviewed-on: https://review.couchbase.org/c/gocb/+/214245
    Reviewed-by: Charles Dixon <chvckd@gmail.com>
    Tested-by: Build Bot <build@couchbase.com>
    DemetrisChr committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    029cd49 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. GOCBC-1657: Update couchbase2 tracing to send trace over grpc

    Motivation
    ----------
    CNG supports allowing us to tie up SDK and CNG trace via the
    relevant grpc property. We should wire this up.
    
    Changes
    --------
    Add new interface for getting otel spans out of the provided
    span to the SDK, if it is an otel span.
    Update context passed into grpc layer to include span info.
    
    Change-Id: I66cdb4bb8b936d0f2c4c7dfc01f78bfc48b28d3c
    Reviewed-on: https://review.couchbase.org/c/gocb/+/214329
    Reviewed-by: Brett Lawson <brett19@gmail.com>
    Tested-by: Build Bot <build@couchbase.com>
    chvck committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fcf55fc View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. GOCBC-1661: Fix intermittent failures in drop non-existent scope/coll…

    …ection tests
    
    Motivation
    ==========
    TestDropNonExistentScope/DropNonExistentCollection create some scopes and collections that are not necessary for the tests to verify the dropping non-existent scope/collection behavior. In TestDropNonExistentScope, EnsureScopeOnAllNodes was not used, resulting in intermittent ScopeNotFound errors on CI.
    
    Changes
    =======
    * Remove unnecessary scope/collection creations in TestDropNonExistentScope and TestDropNonExistentCollection
    * Update these two tests to expect specific errors (ErrScopeNotFound and ErrCollectionNotFound respectively)
    
    Results
    =======
    Tests pass
    
    Change-Id: Ib18532fa8c7bcb5d5a8d092ee47a3f5126330525
    Reviewed-on: https://review.couchbase.org/c/gocb/+/215479
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Mateusz <matt.wozakowski@couchbase.com>
    DemetrisChr committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4be2757 View commit details
    Browse the repository at this point in the history
  2. GOCBC-1663: Fix intermittent failure in TestUpdateCollectionWithMaxEx…

    …piryAsNoExpiry
    
    Motivation
    ==========
    After updating maxTTL on the collection we do not ensure that it has been updated in old nodes. This means the assertion for maxTTL on the GetAllScopes result can sometimes fail.
    
    Change
    ======
    Add EnsureCollectionsSatisfyPredicateOnAllNodes helper to ensure that maxTTL has been updated on all nodes before calling GetAllScopes
    
    Results
    =======
    Tests pass
    
    Change-Id: I1d958184a4754aa56265f5702a4a1c4985e1c260
    Reviewed-on: https://review.couchbase.org/c/gocb/+/215481
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Mateusz <matt.wozakowski@couchbase.com>
    DemetrisChr committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0316f80 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. GOCBC-1665: Update gocbcore version

    Change-Id: Ibef911d6e79d5ec563f2574638cccb739a01a00f
    Reviewed-on: https://review.couchbase.org/c/gocb/+/215905
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Mateusz <matt.wozakowski@couchbase.com>
    DemetrisChr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bedc00b View commit details
    Browse the repository at this point in the history
  2. GOCBC-1664: Fix intermittent expiry assertion failures in range scan …

    …tests
    
    Motivation
    ==========
    The clocks on cbdyncluster and the Jenkins hosts can sometimes be out of sync. This results in the expiry assertiosn of TestRangeScanSampling and TestRangeScanRangeWithContentBinaryTranscoder to fail as the absolute expiry coming from the server doesn't match our expectations.
    
    Change
    ======
    Just check that the expiry in the scan results is positive instead of checking that it's at least 15 seconds, which is what we already do for TestRangeScanRangeWithContent.
    
    Results
    =======
    Tests pass
    
    Change-Id: I8d711c175ed5d125814113df88ae13c28994ed35
    Reviewed-on: https://review.couchbase.org/c/gocb/+/215904
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Mateusz <matt.wozakowski@couchbase.com>
    DemetrisChr committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    57126b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. GOCBC-1662: Allow retries in span assertions for first op in TestAnal…

    …yticsIndexesCrud
    
    Motivation
    ==========
    When running tests on a newly created cluster, it's possible that the analytics service is in a 'temporarily unavailable' state briefly. The SDK correctly retries any 'temporary error' analytics status codes, but the assertion for numDispatchSpans can fail because of the retries.
    
    Change
    ======
    * Allow retries in the tracing assertions for the first operation in TestAnalyticsIndexesCrud
    * Fix AssertHTTPDispatchSpansGE - assertion was checking that len(spans) <= N, instead of len(spans) >= N
    
    Result
    ======
    Test passes - tested by kicking off the test with a cluster that's undergoing a rebalance
    
    Change-Id: I8dc25bb47a7456e295d27bfa3ecc0af2050c6b27
    Reviewed-on: https://review.couchbase.org/c/gocb/+/216095
    Reviewed-by: Jared Casey <jared.casey@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    DemetrisChr committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5c2640b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. GOCBC-1667: Close results channel in zone-aware replica reads when se…

    …rver group is not found
    
    Motivation
    ==========
    The logic that checks if the result channel should be closed is being executed when each replica read finishes. This means that if there are no servers to read from (e.g. when the server group does not exist), the channel is never closed and res.Next() in LookupInAllReplicas/GetAllReplicas never returns.
    
    Change
    ======
    In LookupInAllReplicas/GetAllReplicas, close the channels in the result before returning it, if no replica reads are being performed.
    
    Results
    =======
    Tests pass, including all zone-aware replica read FIT tests
    
    Change-Id: I56807fba7739eeb9784d05613055b7d2bddfa9db
    Reviewed-on: https://review.couchbase.org/c/gocb/+/216670
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    DemetrisChr committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d5cbf58 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. GOCBC-1665: Prepare v2.9.2 release

    Change-Id: I54161988bc256c9e7753a039832a7793c5019ad1
    Reviewed-on: https://review.couchbase.org/c/gocb/+/216685
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Brett Lawson <brett19@gmail.com>
    DemetrisChr committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6da039c View commit details
    Browse the repository at this point in the history
  2. GOCBC-1667: Fix version for ZoneAwareReplicaReadsFeature in tests

    Change-Id: I9bd34a9b9b31894a9004c27229db164be326f983
    Reviewed-on: https://review.couchbase.org/c/gocb/+/216711
    Reviewed-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    DemetrisChr committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    525b88f View commit details
    Browse the repository at this point in the history
Loading