Continue fixing golint errors [T708] #221
Merged
+546
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagovas
reviewed
Jul 26, 2018
| @@ -83,7 +91,7 @@ func (hp HashedPasswords) SetPassword(name, password string) (err error) { | |||
| return nil | |||
| } | |||
|
|
|||
| func ParseHtpasswdFile(file string, keystore *filesystem.FilesystemKeyStore) (passwords HashedPasswords, err error) { | |||
| func parseHtpasswdFile(file string, keystore *filesystem.FilesystemKeyStore) (passwords HashedPasswords, err error) { | |||
There was a problem hiding this comment.
change to private because used only in this module?
Lagovas
reviewed
Jul 26, 2018
cmd/acra-server/acra-server.go
Outdated
| const ( | ||
| TEST_MODE = "true" | ||
| ) | ||
|
|
||
| var TestOnly = "false" | ||
| var testOnly = "false" |
There was a problem hiding this comment.
this variable used on compile time to set test mode - https://github.com/cossacklabs/acra/blob/master/tests/test.py#L292
is it work after renaming and changing to private?
Lagovas
reviewed
Jul 26, 2018
| @@ -8,7 +8,7 @@ import ( | |||
| type TestCallback struct{ CallCount *int } | |||
|
|
|||
| func (callback *TestCallback) Call() error { | |||
| *callback.CallCount += 1 | |||
There was a problem hiding this comment.
python style vs golang style))
Lagovas
requested changes
Jul 26, 2018
that's might be the reason of failing tests. thank you |
Lagovas
approved these changes
Jul 26, 2018
|
awesome results) well done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes include:
Errors number decreased from 788 to 512.