Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EC - check of peak flux #13

Closed
jsitarek opened this issue Apr 27, 2020 · 2 comments
Closed

EC - check of peak flux #13

jsitarek opened this issue Apr 27, 2020 · 2 comments

Comments

@jsitarek
Copy link
Collaborator

In https://github.com/jsitarek/agnpy/blob/master/tests/basic/simple_ec.ipynb I put a few tests of the EC code comparing it with back of the envelope calculations.

in [16] (test2) compares the flux of the EC spectrum for Thomson case without beaming

in [23] (test3) there is the same check done in K-N regime (still without beaming)

in [27] (test4) the same is done for Thomson regime but with strong beaming,

in all the 3 cases the obtained flux is about a factor 2 lower than what I would expect from the back on the envelope calculations
@cosimoNigro cosimoNigro mentioned this issue May 14, 2020
Closed
3 tasks
@jsitarek jsitarek mentioned this issue May 26, 2020
Closed
@cosimoNigro
Copy link
Owner

Can we close this? It's been a while since we get a good agreement for all the EC cases...

@jsitarek
Copy link
Collaborator Author

jsitarek commented May 10, 2021 •
edited
Loading

EDIT (I wrote the earlier comments in wrong issue)

I updated the old notebook in PR #94 reruning it with the current code.
The old differences in photon density are gone now, everything with flux is consistent, so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cosimoNigro @jsitarek