Fix handling of re-used priors #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would use a `memo` set in `_extract_named_priors` that would cause issues / wrong results if the same prior instance was used on different modules. I don't actually understand the reason for having this `memo`, and removing it fies this issue. Separately, we should probably audit similar behavior in `_extract_named_constraints` and `_extract_named_added_loss_terms`. Addresses #2263
gpleiss
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would use a
memoset in_extract_named_priorsthat would cause issues / wrong results if the same prior instance was used on different modules. I don't actually understand the reason for having thismemo, and removing it fies this issue.Separately, we should probably audit similar behavior in
_extract_named_constraintsand_extract_named_added_loss_terms.Addresses #2263