This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
modules/tectonic/resources: make tectonic scripts POSIX #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the tectonic.sh script POSIX compliant. This is necessary because the k8s base image for hyperkube will no longer have bash installed once kubernetes/kubernetes#48365 lands, so bash-specific syntax will cause cluster bootstrapping to fail.
|
Fixes: #1401 |
|
Failed because of baremetal testing flake (#1498). Re-testing. |
|
Same bare-metal issue again. |
|
retest this please |
|
ok to test |
|
Something fishy is happening with the reporting of test outcome. |
alexsomesan
approved these changes
Jul 27, 2017
zbwright
pushed a commit
to zbwright/tectonic-installer
that referenced
this pull request
Jul 27, 2017
This commit makes the tectonic.sh script POSIX compliant. This is necessary because the k8s base image for hyperkube will no longer have bash installed once kubernetes/kubernetes#48365 lands, so bash-specific syntax will cause cluster bootstrapping to fail.
squat
added a commit
to squat/tectonic-installer
that referenced
this pull request
Sep 25, 2017
This commit makes the tectonic.sh script POSIX compliant. This is necessary because the k8s base image for hyperkube will no longer have bash installed once kubernetes/kubernetes#48365 lands, so bash-specific syntax will cause cluster bootstrapping to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the tectonic.sh script POSIX compliant. This is
necessary because the k8s base image for hyperkube will no longer have
bash installed once kubernetes/kubernetes#48365
lands, so bash-specific syntax will cause cluster bootstrapping to fail.
cc @alexsomesan @sym3tri