plugin/timeouts - Allow ability to configure listening server timeouts #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlees85
requested review from
miekg,
chrisohaver,
johnbelamaric,
yongtang,
stp-ip,
bradbeam,
dilyevsky,
jameshartig,
greenpau,
Isolus,
pmoroney,
rajansandeep,
SuperQ and
Tantalor93
as code owners
stickler-ci
reviewed
Nov 29, 2022
stickler-ci
reviewed
Nov 29, 2022
Signed-off-by: Rich <git0@bitservices.io>
rlees85
force-pushed
the
feature/timeouts
branch
from
99c30bb to
1fc3a69
Compare
rlees85
changed the title
Signed-off-by: Rich <git0@bitservices.io>
Signed-off-by: Rich <git0@bitservices.io>
Signed-off-by: Rich <git0@bitservices.io>
|
I think this is as far as I can take this PR. Any guidance in making it good enough for merge would be appreciated. I am not 100% familiar with everything that's going on in CoreDNS and this is my first attempt at Go so only happy to take criticism/suggestions. |
Tantalor93
requested changes
Dec 10, 2022
Signed-off-by: Rich <git0@bitservices.io>
rlees85
commented
Dec 13, 2022
|
Changes submitted for how the plugin should be configured |
chrisohaver
reviewed
Dec 13, 2022
Signed-off-by: Rich <git0@bitservices.io>
rlees85
force-pushed
the
feature/timeouts
branch
from
46f5673 to
8bb15da
Compare
Tantalor93
requested changes
Dec 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #5784 +/- ##
==========================================
+ Coverage 55.70% 57.28% +1.58%
==========================================
Files 224 245 +21
Lines 10016 15731 +5715
==========================================
+ Hits 5579 9011 +3432
- Misses 3978 6173 +2195
- Partials 459 547 +88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @Tantalor93 I will try and get on these improvements when I get a moment |
Signed-off-by: Rich <git0@bitservices.io>
Signed-off-by: Rich <git0@bitservices.io>
Signed-off-by: Rich <git0@bitservices.io>
|
Hopefully that should cover the comments unless I've messed something up (i've ran go tests/etc locally so hopefully not!) |
Tantalor93
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Creates a "timeouts" plugin for configuring the listening server timeouts. Applies to TCP, DNS-over-TLS, DNS-over-HTTPS.
CoreDNS currently has a hard-coded 2 second read timeout for TCP/TLS connections and 5 seconds for HTTPS. This appears to be optimised for local network and/or Kubernetes environments where CoreDNS is most often used. Where CoreDNS is acting as a resolver on the public Internet this 2 second timeout can cause problems particularly on 3G/4G/5G connections where there might be lag.
It also removes the limit of queries per connection since we are enforcing timeouts this makes no sense and can cause some devices to think the DNS server is faulty.
It also removes the 128 requests per connection limit.
Corefileis also added to.gitignorefor easier testing. Happy to revert this if preferred.See more details in below.
2. Which issues (if any) are related?
#5780
3. Which documentation changes (if any) need to be made?
Plugin documentation - included.
4. Does this introduce a backward incompatible change or deprecation?
The only possible issue would be clients that expect the server to close the connection after 128 requests which feels very unlikely.