plugin/file: Use NXDOMAIN response if CNAME target is NXDOMAIN #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
|
looks good. Maybe add a little test? |
chrisohaver
force-pushed
the
file-cnames
branch
from
e340e1b to
04bf4be
Compare
chrisohaver
requested review from
bradbeam,
dilyevsky,
Isolus,
johnbelamaric,
pmoroney,
rajansandeep and
SuperQ
as code owners
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Thanks, test added. |
chrisohaver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris O'Haver cohaver@infoblox.com
1. Why is this pull request needed and what does it do?
As cited in #4288, per https://tools.ietf.org/html/rfc6604#section-3, when following a CNAME chain the response code sent to the client should be the same response code received when resolving the target of the final link in the chain. Strictly this means we should be passing through the exact Rcode received when looking up the final target. But since file uses an alternate response code datatype
file.Resultwhich does not map 1:1 to DNS response codes, making that happen might require some larger scope refactoring. So for now, just addressing response codes that do map.2. Which issues (if any) are related?
fixes #4288
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?