Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .LocalAddr() out of goroutine #4281

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Move .LocalAddr() out of goroutine #4281

merged 1 commit into from
Dec 11, 2020

Conversation

miekg
Copy link
Member

@miekg miekg commented Nov 11, 2020

I don't have theory why this panics, but concurrency has something to do
with it, so get the address before we call the goroutine.

See #4271

Signed-off-by: Miek Gieben miek@miek.nl

@miekg
Move .LocalAddr() out of goroutine
48c2747 
I don't have theory why this panics, but concurrency has something to do
with it, so get the address before we call the goroutine.

See #4271

Signed-off-by: Miek Gieben <miek@miek.nl>
chrisohaver
chrisohaver approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@chrisohaver chrisohaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yongtang yongtang merged commit 108d26e into master Dec 11, 2020
@yongtang yongtang deleted the cache-prefetch branch December 11, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisohaver chrisohaver chrisohaver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miekg @chrisohaver @yongtang