Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Caddy to 1.0.1, and update import path #2961

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Update Caddy to 1.0.1, and update import path #2961

merged 3 commits into from
Jul 3, 2019

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Jul 2, 2019

This fix updates caddy to 1.0.1 and also
updates the import path to github.com/caddyserver/caddy

This fix fixes #2959

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@yongtang
Update Caddy to 1.0.1, and update import path
d4ebb98 
This fix updates caddy to 1.0.1 and also
updates the import path to github.com/caddyserver/caddy

This fix fixes 2959

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@corbot
Copy link

corbot bot commented Jul 2, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked superq (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@corbot corbot bot requested a review from SuperQ July 2, 2019 23:58
@yongtang yongtang mentioned this pull request Jul 2, 2019
Closed
@yongtang yongtang requested a review from miekg July 2, 2019 23:59
@yongtang
Also update plugin.cfg
567fe2a 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

yongtang commented Jul 3, 2019

The failing test is related to github.com/coredns/ci which also needs to be updated. Created a PR coredns/ci#109.

@yongtang
Copy link
Member Author

yongtang commented Jul 3, 2019

There are some circular dependencies here. So I will:

@yongtang yongtang mentioned this pull request Jul 3, 2019
Merged
@yongtang
Update and bump zplugin.go
77fc274 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@codecov-io
Copy link

Codecov Report

Merging #2961 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
+ Coverage   55.61%   55.64%   +0.03%     
==========================================
  Files         205      205              
  Lines       10311    10311              
==========================================
+ Hits         5734     5738       +4     
+ Misses       4159     4155       -4     
  Partials      418      418
Impacted Files Coverage Δ
plugin/pprof/setup.go 94.87% <ø> (ø) ⬆️
plugin/route53/setup.go 76.47% <ø> (ø) ⬆️
plugin/cache/setup.go 54.16% <ø> (ø) ⬆️
plugin/etcd/setup.go 6.17% <ø> (ø) ⬆️
plugin/rewrite/setup.go 68% <ø> (ø) ⬆️
plugin/reload/reload.go 17.02% <ø> (ø) ⬆️
plugin/secondary/setup.go 57.89% <ø> (ø) ⬆️
plugin/autopath/setup.go 56.86% <ø> (ø) ⬆️
plugin/cancel/cancel.go 81.25% <ø> (ø) ⬆️
plugin/metadata/setup.go 65.71% <ø> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c6e3e...77fc274. Read the comment docs.

@yongtang
Copy link
Member Author

yongtang commented Jul 3, 2019

All tests passed so merging.

@yongtang yongtang merged commit f8bba51 into master Jul 3, 2019
@corbot corbot bot deleted the caddy branch July 3, 2019 01:04
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
@yongtang @dna2github
Update Caddy to 1.0.1, and update import path (coredns#2961)
70c79e3 
* Update Caddy to 1.0.1, and update import path

This fix updates caddy to 1.0.1 and also
updates the import path to github.com/caddyserver/caddy

This fix fixes 2959

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Also update plugin.cfg

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update and bump zplugin.go

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@c-mueller c-mueller mentioned this pull request Jul 19, 2019
Closed
@rsvalerio rsvalerio mentioned this pull request Aug 10, 2019
Merged
@prameshj prameshj mentioned this pull request Oct 11, 2019
Closed
@chrisohaver chrisohaver mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ Awaiting requested review from SuperQ SuperQ is a code owner

@miekg miekg Awaiting requested review from miekg miekg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caddy's import path has changed
2 participants
@yongtang @codecov-io