Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag 1.5.1 #2927

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Tag 1.5.1 #2927

merged 1 commit into from
Jun 26, 2019

Conversation

miekg
Copy link
Member

@miekg miekg commented Jun 26, 2019

No description provided.

@miekg
Tag 1.5.1
672e34f 
Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot
Copy link

corbot bot commented Jun 26, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked chrisohaver (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@corbot corbot bot requested a review from chrisohaver June 26, 2019 10:32
yongtang
yongtang approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2927 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2927   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         205      205           
  Lines       10294    10294           
=======================================
  Hits         5730     5730           
  Misses       4146     4146           
  Partials      418      418

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d019d...672e34f. Read the comment docs.

@miekg miekg merged commit 6c33397 into master Jun 26, 2019
@corbot corbot bot deleted the 151-version branch June 26, 2019 11:46
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
@miekg @dna2github
Tag 1.5.1 (coredns#2927)
2213a6d 
Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongtang yongtang yongtang approved these changes

@chrisohaver chrisohaver Awaiting requested review from chrisohaver chrisohaver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miekg @codecov-io @yongtang