Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add any plugin #2801

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Add any plugin #2801

merged 2 commits into from
Apr 28, 2019

Conversation

miekg
Copy link
Member

@miekg miekg commented Apr 27, 2019

This adds the any plugin, a plain copy of coredns/any documented here
https://coredns.io/explugins/any/ as an external plugin.

Fixes: #2785

This adds the any plugin, a plain copy of coredns/any documented here
https://coredns.io/explugins/any/ as an external plugin.

Fixes: #2785

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from stp-ip April 27, 2019 15:28
@corbot
Copy link

corbot bot commented Apr 27, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked stp-ip (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

plugin/any/any.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 27, 2019

Codecov Report

Merging #2801 into master will increase coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
+ Coverage   55.26%   55.28%   +0.01%     
==========================================
  Files         201      203       +2     
  Lines       10203    10225      +22     
==========================================
+ Hits         5639     5653      +14     
- Misses       4147     4155       +8     
  Partials      417      417
Impacted Files Coverage Δ
plugin/any/setup.go 41.66% <41.66%> (ø)
plugin/any/any.go 70% <70%> (ø)
plugin/file/reload.go 76.31% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7fb98...984d574. Read the comment docs.

Signed-off-by: Miek Gieben <miek@miek.nl>
@stp-ip
Copy link
Member

stp-ip commented Apr 28, 2019

LGTM

@miekg miekg merged commit 39bc2af into master Apr 28, 2019
@miekg miekg deleted the add-any branch April 28, 2019 10:46
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
* Add any plugin

This adds the any plugin, a plain copy of coredns/any documented here
https://coredns.io/explugins/any/ as an external plugin.

Fixes: coredns#2785

Signed-off-by: Miek Gieben <miek@miek.nl>

* Stickler bot nit

Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new plugin: any
4 participants