docs: Regenerate all manpages using mmark #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mmark recently became able to create manual pages. This removed the dependency on 'ronn' and just uses mmark (Go program). Re-hookup Makefile.doc to generate the correct header mmark needs to see and regenate them all. Spot checking a few pages suggest they look good and actually better than rendered with ronn, esp. lists in lists. Fixes #2757 Signed-off-by: Miek Gieben <miek@miek.nl>
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked bradbeam (via If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository. The bot understands the commands that are listed here. |
bradbeam
approved these changes
Apr 5, 2019
|
[ Quoting <notifications@github.com> in "Re: [coredns/coredns] docs: Regener..." ]
bradbeam approved this pull request.
> @@ -57,7 +57,7 @@ You can use the `import` "plugin" to include parts of other files, see <https://
If you want to reuse a snippet you can define one with and then use it with *import*.
-~~~ corefile {
+~~~ corefile
does this missing `{` mean anything?
no was actually typo, tripping up some markdown parsers (common mark allows it)
|
|
I really don't know what this failure is trying to tell me: also this doesn't touch any code :/ |
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
Mmark recently became able to create manual pages. This removed the dependency on 'ronn' and just uses mmark (Go program). Re-hookup Makefile.doc to generate the correct header mmark needs to see and regenate them all. Spot checking a few pages suggest they look good and actually better than rendered with ronn, esp. lists in lists. Fixes coredns#2757 Signed-off-by: Miek Gieben <miek@miek.nl>
dna2github
pushed a commit
to dna2fork/coredns
that referenced
this pull request
Jul 19, 2019
Mmark recently became able to create manual pages. This removed the dependency on 'ronn' and just uses mmark (Go program). Re-hookup Makefile.doc to generate the correct header mmark needs to see and regenate them all. Spot checking a few pages suggest they look good and actually better than rendered with ronn, esp. lists in lists. Fixes coredns#2757 Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mmark recently became able to create manual pages. This removed the
dependency on 'ronn' and just uses mmark (Go program).
Re-hookup Makefile.doc to generate the correct header mmark needs to
see and regenate them all.
Spot checking a few pages suggest they look good and actually better
than rendered with ronn, esp. lists in lists.
Fixes #2757