Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s line and add deprecations #2758

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

johnbelamaric
Copy link
Member

Updates the release notes to make the resyncperiod change clearer. Also add myself (though I think we will autogen the authors list from git logs?).

By the way - is this now the right place to track release notes, rather than the Wiki. If so, that's fine but we shouldn't try to do it in two places (we should remove the wiki entry).

@corbot corbot bot requested a review from greenpau April 3, 2019 17:05
@corbot
Copy link

corbot bot commented Apr 3, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked greenpau (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io
Copy link

Codecov Report

Merging #2758 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2758   +/-   ##
=======================================
  Coverage   55.28%   55.28%           
=======================================
  Files         201      201           
  Lines       10198    10198           
=======================================
  Hits         5638     5638           
  Misses       4145     4145           
  Partials      415      415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb94e0...68faf87. Read the comment docs.

@miekg miekg merged commit 90c6d37 into coredns:master Apr 3, 2019
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants