manifest-tool doesn't support mips #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked grobie (via If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository. The bot understands the commands that are listed here. |
|
Hmm. That's unfortunate. Can you add a comment in the Makefile as well, why
mips is handled differently.
Otherwise lgmt
…On Tue, 2 Apr 2019, 21:25 chrisohaver, ***@***.***> wrote:
1. Why is this pull request needed and what does it do?
Looks like linux/mips not supported by manifest-tool ...
manifest-tool push from-args --platforms linux/amd64,linux/arm,linux/arm64,linux/ppc64le,linux/s390x,linux/mips --template chrisohaver/coredns:coredns-ARCH --target chrisohaver/coredns:1.4.0-6f5b294-kubernetai
FATA[0007] Manifest entry for image chrisohaver/coredns:coredns-mips has unsupported os/arch combination: linux/mips
This removes mips from the manifest, and builds it separately.
2. Which issues (if any) are related? 3. Which documentation changes (if
any) need to be made? 4. Does this introduce a backward incompatible
change or deprecation?
------------------------------
You can view, comment on, or merge this pull request online at:
#2753
Commit Summary
- remove mips from manifest
- derp
File Changes
- *M* Makefile.release
<https://github.com/coredns/coredns/pull/2753/files#diff-0> (5)
Patch Links:
- https://github.com/coredns/coredns/pull/2753.patch
- https://github.com/coredns/coredns/pull/2753.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2753>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVkW41MRlX0oMYiuEPvvAP7jHOsWIobks5vc7y_gaJpZM4cZDNl>
.
|
Codecov Report
@@ Coverage Diff @@
## master #2753 +/- ##
=======================================
Coverage 55.28% 55.28%
=======================================
Files 201 201
Lines 10198 10198
=======================================
Hits 5638 5638
Misses 4145 4145
Partials 415 415Continue to review full report at Codecov.
|
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
* remove mips from manifest * derp * add comment
dna2github
pushed a commit
to dna2fork/coredns
that referenced
this pull request
Jul 19, 2019
* remove mips from manifest * derp * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Looks like
linux/mipsis not supported bymanifest-tool...This removes mips from the manifest, and builds it separately.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?