plugin/pprof - add option to enable block profiling #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked miekg (via If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository. The bot understands the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
==========================================
- Coverage 55.15% 55.15% -0.01%
==========================================
Files 199 199
Lines 10164 10170 +6
==========================================
+ Hits 5606 5609 +3
- Misses 4141 4143 +2
- Partials 417 418 +1
Continue to review full report at Codecov.
|
rajansandeep
approved these changes
Mar 26, 2019
miekg
reviewed
Mar 27, 2019
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
* - add an option for block profiling to plugin pprof * - move option block into nested block
dna2github
pushed a commit
to dna2fork/coredns
that referenced
this pull request
Jul 19, 2019
* - add an option for block profiling to plugin pprof * - move option block into nested block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
In order to collect profiling information for blocked routines, we need to set a specific function of runtime.
see changes in the README.
2. Which issues (if any) are related?
This pprof option is useful to investigate the reason of high number of goroutines and associated memory or CPU.
This profiling mode was needed to investigate: #2593
Will allow to investigate the Mem+CPU spike here : #2624
3. Which documentation changes (if any) need to be made?
README is updated
4. Does this introduce a backward incompatible change or deprecation?
no.