Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up the version to 1.4.0 #2642

Merged
merged 1 commit into from
Mar 3, 2019
Merged

up the version to 1.4.0 #2642

merged 1 commit into from
Mar 3, 2019

Conversation

miekg
Copy link
Member

@miekg miekg commented Mar 3, 2019

No description provided.

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot
Copy link

corbot bot commented Mar 3, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked varyoo (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@corbot corbot bot requested a review from varyoo March 3, 2019 10:34
@codecov-io
Copy link

Codecov Report

Merging #2642 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
+ Coverage   55.55%   55.58%   +0.02%     
==========================================
  Files         203      203              
  Lines       10311    10311              
==========================================
+ Hits         5728     5731       +3     
+ Misses       4152     4150       -2     
+ Partials      431      430       -1
Impacted Files Coverage Δ
plugin/route53/route53.go 85.18% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc38a...849ec71. Read the comment docs.

@miekg miekg merged commit 8dcc7fc into master Mar 3, 2019
@corbot corbot bot deleted the 140 branch March 3, 2019 10:41
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
Signed-off-by: Miek Gieben <miek@miek.nl>
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants