Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: bump version to 1.2.4 #2211

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Release: bump version to 1.2.4 #2211

merged 1 commit into from
Oct 17, 2018

Conversation

miekg
Copy link
Member

@miekg miekg commented Oct 17, 2018

Signed-off-by: Miek Gieben miek@miek.nl

Once we have the test in #2204 we are good to go.

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from rajansandeep October 17, 2018 19:27
@corbot
Copy link

corbot bot commented Oct 17, 2018

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked rajansandeep (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io
Copy link

Codecov Report

Merging #2211 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
- Coverage   55.89%   55.84%   -0.06%     
==========================================
  Files         203      203              
  Lines        9991     9991              
==========================================
- Hits         5584     5579       -5     
- Misses       3984     3988       +4     
- Partials      423      424       +1
Impacted Files Coverage Δ
plugin/forward/connect.go 82.43% <0%> (-4.06%) ⬇️
plugin/proxy/lookup.go 71.66% <0%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a044499...d94efdb. Read the comment docs.

@chrisohaver
Copy link
Member

/integration-cipr73

@miekg miekg merged commit 7343c70 into master Oct 17, 2018
@corbot corbot bot deleted the release branch October 17, 2018 21:53
chrisohaver added a commit that referenced this pull request Oct 22, 2018
mdgreenfield pushed a commit to DataDog/coredns that referenced this pull request Mar 4, 2019
Signed-off-by: Miek Gieben <miek@miek.nl>
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
Signed-off-by: Miek Gieben <miek@miek.nl>
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants