Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes #2031

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Typo fixes #2031

merged 1 commit into from
Aug 14, 2018

Conversation

knweiss
Copy link
Contributor

@knweiss knweiss commented Aug 14, 2018

1. Why is this pull request needed and what does it do?

It fixes some spelling mistakes.

2. Which issues (if any) are related?

None.

3. Which documentation changes (if any) need to be made?

Please run make -f Makefile.doc afterwards as I did not patch the generated files (e.g. man pages).

@corbot corbot bot requested a review from chrisohaver August 14, 2018 15:41
@corbot
Copy link

corbot bot commented Aug 14, 2018

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked chrisohaver (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

Copy link
Member

@chrisohaver chrisohaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #2031 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   54.91%   54.93%   +0.02%     
==========================================
  Files         200      200              
  Lines        9725     9725              
==========================================
+ Hits         5340     5342       +2     
+ Misses       3974     3973       -1     
+ Partials      411      410       -1
Impacted Files Coverage Δ
plugin/forward/lookup.go 36.84% <ø> (ø) ⬆️
coremain/run.go 31.3% <ø> (ø) ⬆️
plugin/rewrite/name.go 97.91% <ø> (ø) ⬆️
plugin/hosts/hostsfile.go 76.52% <ø> (ø) ⬆️
plugin/file/xfr.go 0% <ø> (ø) ⬆️
plugin/file/secondary.go 55.12% <ø> (ø) ⬆️
plugin/forward/truncated.go 45.45% <ø> (ø) ⬆️
plugin/etcd/msg/service.go 50% <ø> (ø) ⬆️
plugin/forward/connect.go 82.43% <ø> (ø) ⬆️
plugin/proxy/proxy.go 13.33% <ø> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a77cd...11e46be. Read the comment docs.

@yongtang yongtang merged commit 6d8a078 into coredns:master Aug 14, 2018
mdgreenfield pushed a commit to DataDog/coredns that referenced this pull request Mar 4, 2019
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
dna2github pushed a commit to dna2fork/coredns that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants