Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up release to 1.2.0 #1958

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Up release to 1.2.0 #1958

merged 2 commits into from
Jul 10, 2018

Conversation

miekg
Copy link
Member

@miekg miekg commented Jul 10, 2018

Set the version to 1.2.0, in preparation for our first, completely
automated release.

See #1954

Signed-off-by: Miek Gieben miek@miek.nl

Set the version to 1.2.0, in preparation for our first, completely
automated release.

See #1954

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot
Copy link

corbot bot commented Jul 10, 2018

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked greenpau (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@corbot corbot bot requested a review from greenpau July 10, 2018 08:36
@miekg
Copy link
Member Author

miekg commented Jul 10, 2018

lots of @greenpau for PRs lately. double checking the randomization in dreck

@miekg
Copy link
Member Author

miekg commented Jul 10, 2018

			rand.Seed(int64(time.Now().Nanosecond()))
			rand := rand.Intn(len(withoutPuller))

should be sufficient

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1958 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1958      +/-   ##
==========================================
+ Coverage   54.55%   54.61%   +0.05%     
==========================================
  Files         197      197              
  Lines        9586     9586              
==========================================
+ Hits         5230     5235       +5     
+ Misses       3952     3949       -3     
+ Partials      404      402       -2
Impacted Files Coverage Δ
plugin/forward/persistent.go 98.59% <0%> (+2.81%) ⬆️
plugin/forward/proxy.go 100% <0%> (+3.57%) ⬆️
plugin/file/reload.go 74.28% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9da82...6d4afc5. Read the comment docs.

Signed-off-by: Miek Gieben <miek@miek.nl>
@stp-ip
Copy link
Member

stp-ip commented Jul 10, 2018

/LGTM

Copy link

@corbot corbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by stp-ip

@miekg
Copy link
Member Author

miekg commented Jul 10, 2018 via email

@corbot corbot bot merged commit 2306721 into master Jul 10, 2018
@corbot corbot bot deleted the release-1.2.0 branch July 10, 2018 11:28
@greenpau
Copy link
Collaborator

lots of @greenpau for PRs lately. double checking the randomization in dreck

@miekg , I don't mind 😄 keeps me aware of the code base in rewrite 😃

fturib pushed a commit to fturib/coredns that referenced this pull request Jul 12, 2018
…own. logs and debug information

adding logs on sop/start metrics listener

release: automate the release (coredns#1935)

* release: automate the release

This PR aims to various pieces into place so we can automate the coredns
release. It needs the script from coredns/release to be installed. Dreck
is to be setup as described in coredns/release/README.md

The release-coredns script can be tested and allows for other branches
than master to be test.

This PR also features some cleanup in the Makefile.release so we don't
call the godep target for each linux release - this speeds it up for
some bit.

Manually running ./release-coredns -t auto-release builds the artifects
for this release, but (of course) doesn't upload anything yet.

Add /release to the OWNERS and allow command to be executed (this still
needs to be tested).

Signed-off-by: Miek Gieben <miek@miek.nl>

* that makefile target doesnt exist anymore

Signed-off-by: Miek Gieben <miek@miek.nl>

* test release for now

Signed-off-by: Miek Gieben <miek@miek.nl>

* Slightly better output

Signed-off-by: Miek Gieben <miek@miek.nl>

* remove again

Signed-off-by: Miek Gieben <miek@miek.nl>

Up release to 1.2.0 (coredns#1958)

Automatically submitted.

Various improvements in the release documention. (coredns#1961)

Releasing 1.2.0 uncovered some rough edges that need to be documented.
Also fix github-push target and docker login.

Signed-off-by: Miek Gieben <miek@miek.nl>

- remove debug msgs. Refined logging.
mdgreenfield pushed a commit to DataDog/coredns that referenced this pull request Mar 4, 2019
Automatically submitted.
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
Automatically submitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants