Signal handling breaks parent code (#1763) #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
- Coverage 54.49% 54.48% -0.02%
==========================================
Files 192 192
Lines 9486 9486
==========================================
- Hits 5169 5168 -1
- Misses 3929 3930 +1
Partials 388 388
Continue to review full report at Codecov.
|
miekg
approved these changes
May 3, 2018
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this pull request do?
Moves TrapSignals() invocation from package init to Run
2. Which issues (if any) are related?
#1763
3. Which documentation changes (if any) need to be made?
None