Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/log usage in coremain as well #1751

Merged
merged 1 commit into from
Apr 27, 2018
Merged

pkg/log usage in coremain as well #1751

merged 1 commit into from
Apr 27, 2018

Conversation

miekg
Copy link
Member

@miekg miekg commented Apr 27, 2018

1. What does this pull request do?

2. Which issues (if any) are related?

3. Which documentation changes (if any) need to be made?

@codecov-io
Copy link

Codecov Report

Merging #1751 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1751   +/-   ##
=======================================
  Coverage   54.37%   54.37%           
=======================================
  Files         192      192           
  Lines        9492     9492           
=======================================
  Hits         5161     5161           
  Misses       3942     3942           
  Partials      389      389
Impacted Files Coverage Δ
coremain/run.go 32.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc647d...8de84ac. Read the comment docs.

@miekg miekg merged commit 82d3195 into master Apr 27, 2018
@miekg miekg deleted the log-in-core branch April 27, 2018 20:50
Jason-ZW pushed a commit to rancher/coredns that referenced this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants