Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: some function/vars/const/package level updates #1558

Merged
merged 2 commits into from
Feb 23, 2018
Merged

doc: some function/vars/const/package level updates #1558

merged 2 commits into from
Feb 23, 2018

Conversation

miekg
Copy link
Member

@miekg miekg commented Feb 23, 2018

Various updates that stood out while reading godoc.org for CoreDNS.

Various update that stood out while reading godoc.org for CoreDNS.
@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #1558 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
- Coverage   53.07%   53.05%   -0.03%     
==========================================
  Files         185      185              
  Lines        9275     9275              
==========================================
- Hits         4923     4921       -2     
- Misses       3974     3975       +1     
- Partials      378      379       +1
Impacted Files Coverage Δ
plugin/pkg/up/up.go 96% <ø> (ø) ⬆️
request/request.go 50.58% <ø> (ø) ⬆️
coremain/run.go 32.47% <ø> (ø) ⬆️
core/dnsserver/address.go 51.11% <ø> (ø) ⬆️
plugin/pkg/rcode/rcode.go 100% <ø> (ø) ⬆️
plugin/pkg/parse/parse.go 84.61% <ø> (ø) ⬆️
plugin/forward/setup.go 39% <0%> (ø) ⬆️
plugin/file/reload.go 67.64% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b7bea...a418c12. Read the comment docs.

@miekg miekg merged commit 455040c into master Feb 23, 2018
@miekg miekg deleted the docs branch February 23, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants