Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change T should leave a cast trace #13984

Open
JasonGross opened this issue Mar 23, 2021 · 2 comments
Open

change T should leave a cast trace #13984

JasonGross opened this issue Mar 23, 2021 · 2 comments
Labels
part: tactics

Comments

@JasonGross
Copy link
Member

All the other reduction tactics do, change (in the goal) should as well. At least the version that's not doing change x with y, though ideally that version too. See https://coq.zulipchat.com/#narrow/stream/237977-Coq-users/topic/How.20to.20Debug.20slow.20QED.3F/near/231488512 for more discussion.
@clayrat
Copy link

clayrat commented Nov 29, 2022

I'm guessing this is now closed by #14773 ?

@SkySkimmer SkySkimmer changed the title change T should leave REVERTcast change T should leave a cast trace Feb 21, 2023
SkySkimmer added a commit to SkySkimmer/coq that referenced this issue Feb 21, 2023
@SkySkimmer
Make change create a cast node
3063a84 
Fix coq#13984
@SkySkimmer SkySkimmer mentioned this issue Feb 21, 2023
Closed
SkySkimmer added a commit to SkySkimmer/coq that referenced this issue Feb 22, 2023
@SkySkimmer
Make change create a cast node
e20dc82 
Fix coq#13984
@SkySkimmer
Copy link
Contributor

I'm guessing this is now closed by #14773 ?

no

A change_with_cast could be defined as

(* uconstr or open_constr or constr as you prefer *)
Tactic Notation "change_with_cast" uconstr(c) :=
  match goal with |- ?g => simple notypeclasses refine (_ : g); change c end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part: tactics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make change create a cast node SkySkimmer/coq
4 participants
@clayrat @JasonGross @silene @SkySkimmer