pydocstyle for log.py #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackebrot
reviewed
Oct 15, 2017
cookiecutter/log.py
Outdated
| @@ -18,6 +20,11 @@ | |||
|
|
|||
|
|
|||
| def configure_logger(stream_level='DEBUG', debug_file=None): | |||
| """Configure logging for cookiecutter. | |||
|
|
|||
| Set up logging to stdout with given level and with DEBUG level for loggin | |||
hackebrot
reviewed
Oct 15, 2017
cookiecutter/log.py
Outdated
| """Configure logging for cookiecutter. | ||
|
|
||
| Set up logging to stdout with given level and with DEBUG level for loggin | ||
| to file if debug_file given |
hackebrot
added
code style
|
@hackebrot |
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 780 781 +1
=====================================
+ Hits 780 781 +1
Continue to review full report at Codecov.
|
hackebrot
reviewed
Oct 15, 2017
cookiecutter/log.py
Outdated
| @@ -1,5 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| """Module for up logging set up.""" | |||
There was a problem hiding this comment.
The grammar isn't correct. What are you trying to say?
Module for setting up logging.
|
Thank you for your contribution @meahow! 🙇 |
hackebrot
removed
the
waiting-for-contributor
hackebrot
added a commit
that referenced
this pull request
Nov 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #742
I changed the format of the docstrings for cookiecutter/log.py to follow pep257 style