Handle empty hook file or other OSErrors #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added comment with justification
Current coverage is 99.66%
@@ master #729 diff @@
========================================
Files 13 13
Lines 583 589 +6
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 583 587 +4
- Misses 0 2 +2
Partials 0 0
|
|
Argh... this error might be a *nix specific thing as the same error does not appear to be thrown on Windows. The tests are failing with |
|
@jcarbaugh I think it looks good, but I'd like a second pair of eyes on this before merging. Can someone who has subprocess experience give this a second review? Just comment on the diff with anything that needs improvement. |
audreyfeldroy
added
please-help
| @pytest.mark.usefixtures('clean_system', 'remove_additional_folders') | ||
| def test_empty_hooks(): | ||
|
|
||
| # OSError.errno=8 is not thrown on Windows when the script is emtpy |
|
Looks fine to me, I picked a few nits though @jcarbaugh. |
hackebrot
added a commit
to hackebrot/cookiecutter
that referenced
this pull request
Dec 2, 2016
Merged
hackebrot
added a commit
that referenced
this pull request
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a guess at the right way to test based on the existing tests. Let me know if anything needs to be changed!
Fixes #632.