-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): let husky create commit hook #3371 #3372
fix(docs): let husky create commit hook #3371 #3372
Conversation
Thanks! Seems to be hard top find the right spot for everyonbe here. This has been adjusted quite a bit recently. Happy to merge this but let's see if we can get feedback from @jpbnetley and @sd-godaddy |
Aah yes - I think the solution mentioned in this pull request is a better one. I also tested the hooks creation on macOs, and worked perfectly. :) I think this pr is a good addition in my opinion. :) |
Sounds great. Is there anything I can do to make the pipeline succeed? |
This happens mainly because a contributor does not have a https://circleci.com/ account. Do you have one? |
I just created one. Let me see if I have to configure someting additionally. I cannot rerun the failed jobs right now.. |
119547f
to
6bda8f6
Compare
Yes I think the first one failes because I did the first commit before I created the circleci account. I don't know how I can fix it, but pushing a new commit made the actual test run and pass now :) If it is okay with you, you can go ahead and merge this 👍 |
Haha, damn, commit type should be Thank everyone! Couldn't do this without you! ❤️ |
I failed on commit message in the commitlint project. That's quite an achievement 🤦 😄 |
No worries. I should double check these things really :P |
Done |
Fix the docs for local setup.
Description
The local setup does not work for my environment (MacOS/zsh) and this is a more general approach to generating the commit hook.
Motivation and Context
I already opend issue #3371 for this problem.
Types of changes
Checklist: