Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): let husky create commit hook #3371 #3372

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

TheKangaroo
Copy link
Contributor

Fix the docs for local setup.

Description

The local setup does not work for my environment (MacOS/zsh) and this is a more general approach to generating the commit hook.

Motivation and Context

I already opend issue #3371 for this problem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Thanks! Seems to be hard top find the right spot for everyonbe here. This has been adjusted quite a bit recently. Happy to merge this but let's see if we can get feedback from @jpbnetley and @sd-godaddy

@jpbnetley
Copy link
Contributor

Thanks! Seems to be hard top find the right spot for everyonbe here. This has been adjusted quite a bit recently. Happy to merge this but let's see if we can get feedback from @jpbnetley and @sd-godaddy

Aah yes - I think the solution mentioned in this pull request is a better one.
Since the file creation is handed over to husky. So will hopefully work on different platforms (like windows, macOS, Linux etc).

I also tested the hooks creation on macOs, and worked perfectly. :)

I think this pr is a good addition in my opinion.

:)

@TheKangaroo
Copy link
Contributor Author

Sounds great. Is there anything I can do to make the pipeline succeed?

@escapedcat
Copy link
Member

Sounds great. Is there anything I can do to make the pipeline succeed?

This happens mainly because a contributor does not have a https://circleci.com/ account. Do you have one?

@TheKangaroo
Copy link
Contributor Author

I just created one. Let me see if I have to configure someting additionally. I cannot rerun the failed jobs right now..

@escapedcat
Copy link
Member

image

This might be related to you? Tried but can't really change anything. But the changes look fine and I can also just merge this.

@TheKangaroo
Copy link
Contributor Author

Yes I think the first one failes because I did the first commit before I created the circleci account. I don't know how I can fix it, but pushing a new commit made the actual test run and pass now :) If it is okay with you, you can go ahead and merge this 👍

@escapedcat escapedcat merged commit 4f78cc3 into conventional-changelog:master Sep 12, 2022
@escapedcat
Copy link
Member

Haha, damn, commit type should be docs not fix but ah well... :D

Thank everyone! Couldn't do this without you! ❤️

@TheKangaroo
Copy link
Contributor Author

I failed on commit message in the commitlint project. That's quite an achievement 🤦 😄
Sorry for that...

@TheKangaroo TheKangaroo deleted the fix/docs branch September 12, 2022 08:04
@escapedcat
Copy link
Member

escapedcat commented Sep 12, 2022

No worries. I should double check these things really :P
Might just force-push it.

escapedcat pushed a commit that referenced this pull request Sep 12, 2022
@escapedcat
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants