-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Docs) Local setup does not work #3371
Comments
fixed in #3372 |
Hey all, I have just installed commitlint on OS X 12.6 and following the local setup, when I get to the "test the hook" part I am not getting the husky fail from the hook, just normal git response of "nothing to commit". When I run the first test I have installed the hook via |
@thatryan it seems like you don't have any changes to commit in your second screenshot and therefore git won't even try to create a commit. |
@TheKangaroo Wow that was dumb of me, I misunderstood the doc sorry. I thought just running the commit would trigger the lint test I did not get that I had to actually have something committable lol. Regardless, I staged some files and tried again.. |
no worries.
?
and your husky searched in |
Thank you, apologies for adding here when this issue was my fault. Freaking node wasn't running so npx couldn't be found when I ran the command. All fixed, thank you much. |
No problem at all, I'm glad that I could help :) |
@TheKangaroo thanks for helping out here! ❤️ |
I followed the steps described in local setup
https://commitlint.js.org/#/guides-local-setup?id=add-hook
https://github.com/conventional-changelog/commitlint#add-hook
but when I do a commit, it just failes with
Expected Behavior
Hook is executed successfully
Current Behavior
The hook cannot be executed
Affected packages
Possible Solution
I made it work with a shorter command:
which could replace the following steps from the docs:
Docs
Make hook executable
I'll happily provide a PR to change this in the docs.
If there is any reason to create this hook by hand it think it need to be changed to
to work correctly. (this is the file
npx husky add ...
creates for me)The text was updated successfully, but these errors were encountered: