Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the UI part to a separate subspec #16

Merged
merged 1 commit into from
May 20, 2016
Merged

Moving the UI part to a separate subspec #16

merged 1 commit into from
May 20, 2016

Conversation

hfossli
Copy link
Contributor

@hfossli hfossli commented May 20, 2016

Keeping both Core and UI as default subspecs

@hfossli
Copy link
Contributor Author

hfossli commented May 20, 2016

The Contentful subspec emits some warnings, but I don't think they got introduced now.

➜  Concorde git:(master) ✗ pod lib lint

 -> Concorde (0.1.1)
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFNetworkReachabilityManager.m:111:17: warning: method override for the designated initializer of the superclass '-init' not found [-Wobjc-designated-initializers]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/usr/include/objc/NSObject.h:60:1: note: method marked as designated initializer of the class here
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLConnectionOperation.m:159:17: warning: method override for the designated initializer of the superclass '-init' not found [-Wobjc-designated-initializers]
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLSessionManager.m:319:62: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLSessionManager.m:319:92: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:85:73: warning: 'NSGregorianCalendar' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarIdentifierGregorian instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSLocale.h:115:36: note: 'NSGregorianCalendar' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:65: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:65:2: note: 'NSYearCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:86: warning: 'NSMonthCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitMonth instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:66:2: note: 'NSMonthCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:108: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:67:2: note: 'NSDayCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:63: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:84: warning: 'NSWeekdayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitWeekday instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:72:2: note: 'NSWeekdayCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:108: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:820:74: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:823:70: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/objc/NSObject.h:60:1: note: method marked as designated initializer of the class here

[!] Concorde did not pass validation, due to 13 warnings (but you can use `--allow-warnings` to ignore them).

neonichu
neonichu reviewed May 20, 2016
View reviewed changes
Concorde.podspec
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Concorde"
s.version = "0.1.0"
s.version = "0.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this change? I prefer doing the version bump as its own separate change later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, I didn't know podspecs could be updated therefore I created a new version.

@neonichu
Copy link
Contributor

LGTM except for the one comment, thanks for the PR! The warnings were indeed there already.

@hfossli
Copy link
Contributor Author

hfossli commented May 20, 2016

Even though the version number is unchanged, are you still able to publish the new version of the podspec? We don't support swift yet on our project you see.

@neonichu
Copy link
Contributor

No, but I'll update the version number as part of my normal release workflow after this has been merged.

@hfossli
Moving the UI part to a separate subspec
82834cc 
Keeping both Core and UI as default subspecs
@hfossli
Copy link
Contributor Author

hfossli commented May 20, 2016

Squashed

@neonichu
Copy link
Contributor

Awesome, thanks for the contribution!

@neonichu neonichu merged commit be97eba into contentful-labs:master May 20, 2016
@neonichu neonichu mentioned this pull request May 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfossli @neonichu