-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arch Toolbox container image #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erazemkokot, thanks for your interest in Toolbox and for this PR. I left some comments.
# Clean up all local caches | ||
RUN pacman -Scc | ||
|
||
CMD /bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to build the image and when I got to this point, it errored out with no such command
. That'll probably need some investigation??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested pacman -Scc
and it works fine, did you mean no such command for /bin/sh or pacman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CMD /bin/sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll check it out (I'm pretty sure it was because bash
is a part of the base
metapackage now and I haven't added it yet when you were testing the image).
@HarryMichal Thanks for the reply. Can you please tell me what I need to do to properly run the container, since I get the error in the first comment and can't even start it. |
Disclaimer: I'm no expert at building container images. I'm still discovering this. First, you need to build the image before you can use it with Toolbox. My process looked like this:
The podman command can be replaced by Maybe we should expand the README (or the GitHub Wiki or even the Fedora Wiki) with some instructions for image building. What do you think @debarshiray, @juhp?? |
I haven't read much documentation on podman yet, but I, and I'm sure a lot of other people, would appreciate a section in the readme dedicated to manually building images. |
If you're using an up-to-date Otherwise using |
@erazemkokot In Fedora the approach was to take a selection of the packages and re-install them. Ubuntu container had a script |
I'll check, thanks for the warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this, and can confirm that it works (toolbox create
and toolbox enter
).
For it to work I had to change two things in toolbox itself:
- When bind-mounting a file, create the target path if it doesn't exist #404 When bind-mounting a file, create the target path if it doesn't exist
- Don't try to remove /media if it doesn't exist #405 Don't try to remove /media if it doesn't exist
Co-Authored-By: Reto Kaiser <reto@retoonline.com>
Co-Authored-By: Reto Kaiser <reto@retoonline.com>
Build succeeded.
|
I'm going to close this to give it a new - clean - shot, keeping in mind all the tips I got so far. |
I'm creating an Arch base for toolbox.
Currently I get the error
toolbox: failed to get the tag of image ./Dockerfile
and I'm new to Podman/Buildah, so I don't know how to tag the file or if I should even use either of those to make the image.Todo: