Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis -> Cirrus: MacOS Cross test #1252

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Travis -> Cirrus: MacOS Cross test #1252

merged 1 commit into from
Apr 21, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Apr 19, 2021 •
edited
Loading

Fixes #1213

Depends on: #1249

Also cleanup Makefile WRT ${DESTDIR} definition and use to make it's
purpose more clear.

@cevich cevich force-pushed the travis_osx_to_cirrus branch 3 times, most recently from fe01f93 to a14e9b9 Compare April 19, 2021 15:21
@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2021

LGTM

@cevich
Travis -> Cirrus: MacOS Cross test
a81cd74 
Also cleanup `Makefile` WRT `${DESTDIR}` definition and use to make it's
purpose more clear.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the travis_osx_to_cirrus branch from a14e9b9 to a81cd74 Compare April 21, 2021 14:47
@cevich cevich marked this pull request as ready for review April 21, 2021 14:48
@cevich
Copy link
Member Author

cevich commented Apr 21, 2021

Rebased. This is ready.

@rhatdan rhatdan merged commit 87f3684 into containers:master Apr 21, 2021
@Foxboron
Copy link
Contributor

Foxboron commented May 22, 2021 •
edited
Loading

Not to be that guy, but that PREFIX and DESTDIR change shouldn't have been merged.

make PREFIX="/usr" DESTDIR="$pkgdir" install is how it should work, but this pull-request changes it to the more awkward make PREFIX="$pkgdir/usr" DESTDIR="$pkgdir" install.

I'd like to partially revert this change.

Thoughts @cevich @rhatdan?

@rhatdan
Copy link
Member

rhatdan commented May 24, 2021

I agree, I am fine with reverting that part. We should keep this simple for the more common case and complicate it for the CI system.

@mtrmac mtrmac mentioned this pull request Jun 23, 2021
Merged
@mtrmac
Copy link
Contributor

mtrmac commented Jun 23, 2021

Not to be that guy, but that PREFIX and DESTDIR change shouldn't have been merged.

I have filed #1331, let’s follow up there.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cevich @rhatdan @Foxboron @mtrmac