Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions for NixOS #604

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add installation instructions for NixOS #604

merged 1 commit into from
Apr 26, 2023

Conversation

bernardpaulus
Copy link
Contributor

Hello,

I thought about adding installation instructions for NixOS.

I checked the code of conduct and the readme, but if I missed any other guideline, don't hesitate to notify me and I'll do the necessary :)

Signed-off-by: Bernard Paulus <bprecyclebin@gmail.com>
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that's all we need to install podman on nixos. This seems to be consistent with the nixos wiki link, but that's the extent of my understanding.

I'd also like to double check if the podman nixos package is actively being maintained. We had some issues with the skopeo nixos package in the past containers/skopeo#1463

#### [NixOS](https://nixos.org/)

```nix
virtualisation.podman.enable = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about nixos, but just double checking that there are no other preceeding / succeeding commands to install podman.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, and this looks reasonable, and the like is especially good.

name: Bernard Paulus
display_name: Bernard Paulus
email: bernard.paulus@gmail.com
github: bernardpaulus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is only needed if you plan to write a blog post for the site, and we've archived the posts for everything but release announcements. Doesn't hurt, and we'll keep it, just thought I'd whip up a quick comment. blogs.podman.io is the new home for the blog posts pertaining to podman fwiw.

@TomSweeneyRedHat
Copy link
Member

LGTM, thansk for the contribution @bernardpaulus !

@TomSweeneyRedHat TomSweeneyRedHat merged commit d7208dd into containers:main Apr 26, 2023
@bernardpaulus bernardpaulus deleted the main-with-dco branch May 24, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants