Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sameFile() to recognize empty files as the same #153

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Fix sameFile() to recognize empty files as the same #153

merged 2 commits into from
Jul 4, 2020

Conversation

tomfaulhaber
Copy link
Contributor

This PR fixes issue #152 and adds a test for that case.

@tomfaulhaber
Fix sameFile() to recognize empty files as the same
11900e8 
Signed-off-by: Tom Faulhaber <tffaulha@amazon.com>
dmcgowan
dmcgowan approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow reviewed Jul 3, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see nit..

fs/path.go Outdated Show resolved Hide resolved
@tomfaulhaber
Add a comment to clarify that we're handling the empty file case
5a33969 
Signed-off-by: Tom Faulhaber <tffaulha@amazon.com>
@dmcgowan dmcgowan merged commit cf53015 into containerd:master Jul 4, 2020
@cpuguy83 cpuguy83 mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow left review comments

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomfaulhaber @dmcgowan @cpuguy83 @mikebrow