Makefile: Remove hcsshim related TODO #8728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a todo for the windows variant of dependency installation that hinted at making an install-hcsshim.sh script, however Windows today doesn't rely on a standalone OCI runtime binary that gets invoked by the shim. Rather, container creation/management is all handled by the shim itself in-proc. Due to this, `make` or `make binaries` basically fulfills that purpose as it clones hcsshim and builds the shim along with containerd. Signed-off-by: Danny Canter <danny@dcantah.dev>
estesp
approved these changes
Jun 23, 2023
sparr
approved these changes
Jun 24, 2023
kiashok
added a commit
to kiashok/containerd-containerd
that referenced
this pull request
Oct 23, 2024
…/main Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a todo for the windows variant of dependency installation that hinted at making an install-hcsshim.sh script, however Windows today doesn't rely on a standalone OCI runtime binary that gets invoked by the shim. Rather, container creation/management is all handled by the shim itself in-proc. Due to this,
makeormake binariesbasically fulfills that purpose as it clones hcsshim and builds the shim along with containerd.Note
If anyone knows of some other dependencies that are required (or nice to haves) for windows let me know and we can hi-jack this PR to add them instead.