Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri: drop unused arg from generateRuntimeOptions #8708

Merged
merged 1 commit into from
Jun 22, 2023
Merged

cri: drop unused arg from generateRuntimeOptions #8708

merged 1 commit into from
Jun 22, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jun 19, 2023

No description provided.

@marquiz
cri: drop unused arg from generateRuntimeOptions
f60a4a2 
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
@k8s-ci-robot
Copy link

Hi @marquiz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AkihiroSuda
Copy link
Member

/ok-to-test

@AkihiroSuda
Copy link
Member

/retest

1 similar comment
@marquiz
Copy link
Contributor Author

marquiz commented Jun 20, 2023

/retest

@akhilerm
Copy link
Member

The test failure in pull-containerd-node-e2e should be fixed after merging kubernetes/kubernetes#118754

@akhilerm
Copy link
Member

/retest

@marquiz marquiz mentioned this pull request Jun 22, 2023
Merged
@dcantah
Copy link
Member

dcantah commented Jun 22, 2023

This is ready to check in

@estesp estesp merged commit 2353574 into containerd:main Jun 22, 2023
@marquiz marquiz deleted the devel/cri-cleanup branch July 17, 2023 10:28
kiashok added a commit to kiashok/containerd-containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 8369437: Update fork-external/main with upstream containerd…
6b2c041 
…/main

Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main

Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@estesp estesp estesp approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marquiz @k8s-ci-robot @AkihiroSuda @akhilerm @dcantah @samuelkarp @estesp