No more nondistributable layers in MS registry #8685
Conversation
Microsoft announced the removal of nondistributable layers from their images today. This makes the convert test fail since it assumes the first layer is nondistributable on Windows during the test. Signed-off-by: Phil Estes <estesp@amazon.com>
estesp
added
cherry-pick/1.6.x
|
Per this announcement and recent failures in CI on PR #8684: https://techcommunity.microsoft.com/t5/containers/announcing-removal-of-foreign-layers-from-windows-container/ba-p/3846833 |
|
A quick survey of all uses, this looks like the only test that works with upstream/registry content; the rest create test-originated manifests with the nondistributable media type. Uses in the containerd code base seem to all be switch statements on the various media types and make no assumptions that there has to be non-distributable layers. |
|
Question: Does the windows test image that we use always have a single layer. It doesnt matter with this change, but got confused how this test may have passed if we were using an image with multiple layers |
|
@akhilerm Yea, nanoserver (at least 2019 and 2022, not sure about prior) has one layer from what I've seen. We might've been getting lucky 😆 |
estesp
added
cherry-picked/1.6.x
…/main Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Microsoft announced the removal of nondistributable layers from their images today. This makes the convert test fail since it assumes the first layer is nondistributable on Windows during the test.