Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace some basic uses of fmt.Sprintf() #8672

Merged
merged 1 commit into from
Jun 11, 2023
Merged

replace some basic uses of fmt.Sprintf() #8672

merged 1 commit into from
Jun 11, 2023

Conversation

thaJeztah
Copy link
Member

Really tiny gains here, and doesn't significantly impact readability:

BenchmarkSprintf
BenchmarkSprintf-10    11528700     91.59 ns/op   32 B/op  1 allocs/op
BenchmarkConcat
BenchmarkConcat-10    100000000     11.76 ns/op    0 B/op  0 allocs/op

@thaJeztah
replace some basic uses of fmt.Sprintf()
577696f 
Really tiny gains here, and doesn't significantly impact readability:

    BenchmarkSprintf
    BenchmarkSprintf-10    11528700     91.59 ns/op   32 B/op  1 allocs/op
    BenchmarkConcat
    BenchmarkConcat-10    100000000     11.76 ns/op    0 B/op  0 allocs/op

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@kzys kzys merged commit cf52175 into containerd:main Jun 11, 2023
@thaJeztah thaJeztah deleted the save_some_trees branch June 11, 2023 13:38
kiashok added a commit to kiashok/containerd-containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 8369437: Update fork-external/main with upstream containerd…
6b2c041 
…/main

Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main

Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@kzys kzys kzys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @kzys @cpuguy83 @dcantah