Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): minor fix on the windows installation steps #8582

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

chschumacher1994
Copy link
Contributor

If this command is used without the parameter "-Container:$false" and the "containerd" directory does not already exist all files will be merged into a single "containerd" file instead of a new directory.

If this command is used without "-Container:$false" and the "containerd" directory does not already exist all files will be merged into a single "containerd" file instead of a new directory.

Signed-off-by: chschumacher1994 <115921143+chschumacher1994@users.noreply.github.com>
@k8s-ci-robot
Copy link

Hi @chschumacher1994. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmcgowan dmcgowan added the platform/windows Windows label May 30, 2023
@kzys kzys merged commit 45d78fb into containerd:main Jun 1, 2023
@dmcgowan
Copy link
Member

dmcgowan commented Nov 1, 2023

@chschumacher1994 What is your name that we can use for the change log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants