fix: cio.Cancel() should close the pipes #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fixes containerd#8326. Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
|
Hi @davidhsingyuchen. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 task
|
@AkihiroSuda PTAL, thanks! |
AkihiroSuda
approved these changes
May 18, 2023
|
/ok-to-test |
AkihiroSuda
added
the
cherry-pick/1.7.x
AkihiroSuda
reviewed
May 18, 2023
| cancel: cancel, | ||
| cancel: func() { | ||
| cancel() | ||
| for _, c := range pipes.closers() { |
|
thanks, LGTM |
kzys
approved these changes
May 31, 2023
davidhsingyuchen
pushed a commit
to davidhsingyuchen/containerd
that referenced
this pull request
Jun 1, 2023
fix: cio.Cancel() should close the pipes
davidhsingyuchen
pushed a commit
to davidhsingyuchen/containerd
that referenced
this pull request
Jun 1, 2023
fix: cio.Cancel() should close the pipes (cherry picked from commit 9e834e7) Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
estesp
added
cherry-picked/1.7.x
kiashok
added a commit
to kiashok/containerd-containerd
that referenced
this pull request
Oct 23, 2024
…/main Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #8326 (tested locally on my side). I'm not an expert of containerd though, so I'm not 100% sure if this has any negative side effects, and I appreciate any guidance on how this should be approached, thanks!